Removal of the Blinking lights
-
SACU wrecks are still part of the game.
A work of art is never finished, merely abandoned
-
If they wouldnt be you'd have me crying about it all day
-
Sleep tight blinking lights, jip is gonna flip the switch off.
-
@jip said in Removal of the Blinking lights:
SACU wrecks are still part of the game.
well, they were removed on 25 May 2020
https://github.com/FAForever/fa/commit/dbaf939f45671a9f77d9cabe099e25068729d452But it looks like those changes were reverted half a year later (25 Nov 2020).
Ok, the SACU wreck question is solved, lets get back to the blinking lights.
-
I'm fine with having some form of lights, made once when the unit is finished and then 'forgotten'. But I'd like to stress: if only a few individuals actually knew about the lights, then why do we bother
.A work of art is never finished, merely abandoned
-
What the lights? Player with low graphics settings
-
@jip said in Removal of the Blinking lights:
But I'd like to stress: if only a few individuals actually knew about the lights, then why do we bother
Because we try to preserve the game SC:FA here. If there is no pressing reason to remove nice details then why should we do that?
If we remove the color changes that are a performance hog, then what do we actually improve if we completely remove the lights? At that point we are just taking stuff away for no good reason.
-
Fair enough - I'll add them back in but without the color changing. Suggestions for a color?
-
@jip said in Removal of the Blinking lights:
Suggestions for a color?
Well i can see yellow and blue best.
-
I would obviously vote for yellow or blue.
-
Also nice; light in faction color
-
Or just white light (in this case yellow white like an old light bulb)
-
Increase the size of the light.
(maybe people will see a "new" feature in the game - "ambient lights"
)
And thanks for keeping the lights!
-
-
Could we not do some sort of vote? I see no point in the lights if they have a performance cost.
-
There was some discussion on preserving current behaviour without the performance penalty. Maybe that's the best option?
-
The performance cost is in having the lights change. If they remain the same, then they're essentially free of charge.
-
The details person in me wants the blinking lights to match the faction colour if they are static. But I couldn't see a blue blinky light.
-
We can make them match the faction colors. Fine by me too
. -
I think the blinking lights should contrast the faction color— i.e. Cybran should have yellow blinking lights and Seraphim blue blinking lights. Aeon should have red lights and UEF green lights.
put the xbox units in the game pls u_u
-
From what I understood of the explanation, it's possible to handle stalling/not stalling color change in a single loop instance, right? So that we pay a tiny fixed cost for the stalling/not stalling logic, and the rest is handled by some shader magic. All the other logic like building units and such could then be placed in appropriate functions instead of being polled every tick. Then we'd keep the old behaviour without polling everything all the time.
-
@mazornoob said in Removal of the Blinking lights:
From what I understood of the explanation, it's possible to handle stalling/not stalling color change in a single loop instance, right? So that we pay a tiny fixed cost for the stalling/not stalling logic,
I've explained it in this post.
and the rest is handled by some shader magic.
Possible, but that doesn't remove all the issues as described in the post mentioned.
All the other logic like building units and such could then be placed in appropriate functions instead of being polled every tick. Then we'd keep the old behaviour without polling everything all the time.
If you don't poll enough then the results are not accurate enough to be reliable, and if they're not reliable then why are we having them change at all?
I've decided to keep the lights, set to a fixed color. There will be no changes to the lights once they've spawned in. I'm fine with any color, they can be faction dependent. Uveso and Zelda made some suggestions:
@uveso said in Removal of the Blinking lights:
- I would obviously vote for yellow or blue.
- Also nice; light in faction color
- Or just white light (in this case yellow white like an old light bulb)
@zeldafanboy said in Removal of the Blinking lights:
I think the blinking lights should contrast the faction color— i.e. Cybran should have yellow blinking lights and Seraphim blue blinking lights. Aeon should have red lights and UEF green lights.
Any other opinions?
-
J Jip referenced this topic on
-
Another option is make the lights the player colour.
-
@zeldafanboy said in Removal of the Blinking lights:
I think the blinking lights should contrast the faction color— i.e. Cybran should have yellow blinking lights and Seraphim blue blinking lights. Aeon should have red lights and UEF green lights.
yes, i think this is the best solution.
-
You just shuffled the faction colors around and I can't even figure out the logic which color goes to which faction, this isn't really contrast in an aesthetic sense. Using the player color seems like the better solution.
