Where my python coders at?
-
@askaholic yes, I am KaletheQuick.
Sorry for not getting to you sooner.
-
@Askaholic Also no guarantees how often I will be able to at the moment, but you can add https://github.com/Exselsior100
-
Great, thanks! No worries @Exselsior, I’m going to try something new which is to create a reviewers group and then request the whole group for review, so hopefully at least a few people from the group will be able to find time for a quick review.
-
Invites have been sent. You'll need to accept them before GitHub will let me request you as reviewers.
-
@askaholic Just accepted. Don't know how much assistance I will be, but I'll do my best and hopefully learn in the process
️ -
@askaholic
I may be blind, but I can't find an invite. I assume it should just be in the github notifications? -
@cheeseberry I got my invite from an email
-
jup it was in my mails, ty!
-
@KaletheQuick @CheeseBerry @Exselsior Please check your email, I requested y’all for a review. Also thanks to @Aulex for reviewing already.
-
@KaletheQuick @CheeseBerry @Exselsior @Aulex (or anyone else) review away!
https://github.com/FAForever/server/pull/867
https://github.com/FAForever/server/pull/828 -
@askaholic alright. I actually have a day off next week, and have been brushing up on my python
-
Need help from any and all who see this. This is a very important pr for making it so that people who frequently cause matchmaker games to fail will be prevented from queuing for a certain period of time.
https://github.com/FAForever/server/pull/885
It needs to be reviewed and tested. Hopefully I’ll find some time to organize this soonTM.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login